feat: Update version to 1.3.1 and ensure title trimming in DynamicPollWebPart
This commit is contained in:
@@ -4,7 +4,7 @@
|
|||||||
"name": "dynamic-poll-web-part",
|
"name": "dynamic-poll-web-part",
|
||||||
"title": "dynamic-poll-web-part",
|
"title": "dynamic-poll-web-part",
|
||||||
"id": "900239c9-b6c7-495d-a386-2d08a81a66f3",
|
"id": "900239c9-b6c7-495d-a386-2d08a81a66f3",
|
||||||
"version": "1.3.0.0",
|
"version": "1.3.1.0",
|
||||||
"includeClientSideAssets": true,
|
"includeClientSideAssets": true,
|
||||||
"skipFeatureDeployment": true
|
"skipFeatureDeployment": true
|
||||||
},
|
},
|
||||||
|
|||||||
+1
-1
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "dynamic-poll-web-part",
|
"name": "dynamic-poll-web-part",
|
||||||
"version": "1.3.0",
|
"version": "1.3.1",
|
||||||
"private": true,
|
"private": true,
|
||||||
"main": "lib/index.js",
|
"main": "lib/index.js",
|
||||||
"engines": { "node": ">=6.9.0 <9.0.0" },
|
"engines": { "node": ">=6.9.0 <9.0.0" },
|
||||||
|
|||||||
@@ -172,7 +172,7 @@ export default class DynamicPollWebPart extends BaseClientSideWebPart<IDynamicPo
|
|||||||
pollNavigationLabel: strings.PollNavigationLabel
|
pollNavigationLabel: strings.PollNavigationLabel
|
||||||
};
|
};
|
||||||
const element: React.ReactElement<IDynamicPollCollectionProps> = React.createElement(DynamicPollCollection, {
|
const element: React.ReactElement<IDynamicPollCollectionProps> = React.createElement(DynamicPollCollection, {
|
||||||
title: this.properties.title || strings.DefaultTitle,
|
title: String(this.properties.title || '').trim(),
|
||||||
snapshots: snapshots,
|
snapshots: snapshots,
|
||||||
displayMode: this.properties.displayMode === 'accordion' ? 'accordion' : 'slider',
|
displayMode: this.properties.displayMode === 'accordion' ? 'accordion' : 'slider',
|
||||||
showResultsBeforeVote: this.properties.showResultsBeforeVote === true,
|
showResultsBeforeVote: this.properties.showResultsBeforeVote === true,
|
||||||
|
|||||||
@@ -16,7 +16,7 @@ var component = read('src/webparts/dynamicPoll/components/DynamicPoll.tsx');
|
|||||||
var collection = read('src/webparts/dynamicPoll/components/DynamicPollCollection.tsx');
|
var collection = read('src/webparts/dynamicPoll/components/DynamicPollCollection.tsx');
|
||||||
var styles = read('src/webparts/dynamicPoll/components/DynamicPoll.module.scss');
|
var styles = read('src/webparts/dynamicPoll/components/DynamicPoll.module.scss');
|
||||||
|
|
||||||
assert(packageJson.version === '1.3.0' && solution.version === '1.3.0.0', 'Version mismatch.');
|
assert(packageJson.version === '1.3.1' && solution.version === '1.3.1.0', 'Version mismatch.');
|
||||||
assert(solution.includeClientSideAssets === true && solution.skipFeatureDeployment === true, 'Central deployment missing.');
|
assert(solution.includeClientSideAssets === true && solution.skipFeatureDeployment === true, 'Central deployment missing.');
|
||||||
assert(packageJson.name === 'dynamic-poll-web-part' && solution.name === 'dynamic-poll-web-part' &&
|
assert(packageJson.name === 'dynamic-poll-web-part' && solution.name === 'dynamic-poll-web-part' &&
|
||||||
solution.title === 'dynamic-poll-web-part', 'Dynamic Poll package naming is inconsistent.');
|
solution.title === 'dynamic-poll-web-part', 'Dynamic Poll package naming is inconsistent.');
|
||||||
@@ -31,6 +31,8 @@ assert(webPart.indexOf("PropertyPaneDropdown('pollKeyField'") >= 0 &&
|
|||||||
assert(webPart.indexOf("PropertyPaneTextField('title'") >= 0 &&
|
assert(webPart.indexOf("PropertyPaneTextField('title'") >= 0 &&
|
||||||
collection.indexOf('styles.webPartHeading') >= 0,
|
collection.indexOf('styles.webPartHeading') >= 0,
|
||||||
'Configurable web part title is missing.');
|
'Configurable web part title is missing.');
|
||||||
|
assert(webPart.indexOf("String(this.properties.title || '').trim()") >= 0,
|
||||||
|
'An empty web part title must remain hidden.');
|
||||||
assert(webPart.indexOf("PropertyPaneDropdown('displayMode'") >= 0 &&
|
assert(webPart.indexOf("PropertyPaneDropdown('displayMode'") >= 0 &&
|
||||||
webPart.indexOf('DynamicPollCollection') >= 0, 'Multiple-poll display mode is missing.');
|
webPart.indexOf('DynamicPollCollection') >= 0, 'Multiple-poll display mode is missing.');
|
||||||
assert(service.indexOf('getSnapshots') >= 0 && service.indexOf('getActivePolls') >= 0,
|
assert(service.indexOf('getSnapshots') >= 0 && service.indexOf('getActivePolls') >= 0,
|
||||||
|
|||||||
Reference in New Issue
Block a user